fix: keep schema hash on by default, omit via -schemaHash=false#59
Merged
Conversation
v0.27.0 made schema hash emission opt-in (default off), a breaking change for consumers that rely on the hash and version constants. Restore the hash to on by default and make omission opt-out instead. - default (or -schemaHash): hash + version constants emitted, as before v0.27.0. - -schemaHash=false: omits the hash from the header comment and the version constants (WebrpcVersion, WebrpcSchemaVersion, WebrpcSchemaHash). The "Code generated by ... DO NOT EDIT." line stays. Regenerated _examples (hash restored).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v0.27.0 flipped the schema-hash default to off (opt-in). webrpc's maintainer wants the hash to stay on by default and always show up in PRs, so this restores hash-on by default and makes omission opt-out via
-schemaHash=falseinstead. Net vs the last good release (v0.26.0): identical default output, plus the new opt-out. Ships as v0.28.0.Behavior
-schemaHash: hash in the header +WebrpcVersion/WebrpcSchemaVersion/WebrpcSchemaHash(pre-v0.27.0 output).-schemaHash=false: omits the hash from the header comment and the three constants. TheDO NOT EDITline stays.Test plan