Add per-job timeouts to all CI workflows#195
Open
julek-wolfssl wants to merge 1 commit into
Open
Conversation
Jobs default to GitHub's 6 hour timeout, so a hung apt step recently burned ~6 hours before the run failed. Add explicit timeout-minutes to every job so hangs fail fast. Timeouts are tiered by job weight: 15 min for lint/metadata, 30 min for standard builds, 60 min for matrix analysis (clang-tidy, scan-build, sanitizers) and NSS tests, 90 min for QEMU-emulated Alpine builds. unit-test.yml calls reusable workflows, which cannot set timeout-minutes on the caller, so its timeout is set in build-workflow.yml and wolfssl-v5.6.6-build-workflow.yml. Pre-existing timeouts are unchanged.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds explicit per-job timeout-minutes settings across CI workflows to avoid hung jobs consuming GitHub’s default 6-hour timeout and to fail faster when steps stall.
Changes:
- Added 15/30/60/90-minute job timeouts based on job “weight” (lint/metadata, standard builds, analysis/NSS, QEMU Alpine).
- Added timeouts inside reusable workflows (
build-workflow.yml,wolfssl-v5.6.6-build-workflow.yml) so callers likeunit-test.ymlinherit them appropriately. - Left pre-existing timeouts unchanged (e.g., existing short timeouts in
tpm2-store-test.ymlbuild jobs).
Reviewed changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/wolfssl-v5.6.6-build-workflow.yml | Adds a 30-minute timeout to the reusable wolfSSL v5.6.6 build job. |
| .github/workflows/wolfssl-master-compatibility.yml | Adds a 30-minute timeout to the wolfSSL master compatibility job. |
| .github/workflows/tpm2-store-test.yml | Adds timeouts to metadata jobs (15 min) and the main test job (30 min). |
| .github/workflows/storage-upgrade-test.yml | Adds a 30-minute timeout to the storage upgrade matrix job. |
| .github/workflows/storage-upgrade-test-tpm.yml | Adds a 30-minute timeout to the TPM storage upgrade matrix job. |
| .github/workflows/scan-build.yml | Adds a 60-minute timeout to the scan-build matrix analysis job. |
| .github/workflows/sanitizer-tests.yml | Adds a 60-minute timeout to the sanitizer matrix job. |
| .github/workflows/nss-ssltap-test.yml | Adds a 60-minute timeout to the NSS SSLTap test job. |
| .github/workflows/nss-pk12util-test.yml | Adds a 60-minute timeout to the NSS pk12util test job. |
| .github/workflows/nss-pk12util-debian-test.yml | Adds a 60-minute timeout to the Debian-container NSS pk12util job. |
| .github/workflows/nss-pdfsig-test.yml | Adds a 60-minute timeout to the NSS PDF signing test job. |
| .github/workflows/nss-curl-test.yml | Adds a 60-minute timeout to the NSS curl test job. |
| .github/workflows/nss-cmsutil-test.yml | Adds a 60-minute timeout to the NSS cmsutil test job. |
| .github/workflows/firefox.yml | Adds a 30-minute timeout to the Firefox container-based test job. |
| .github/workflows/empty-pin-store-test.yml | Adds a 30-minute timeout to the empty PIN store test job. |
| .github/workflows/debian-package-test.yml | Adds a 30-minute timeout to the Debian packaging test job. |
| .github/workflows/codespell.yml | Adds a 15-minute timeout to the codespell job. |
| .github/workflows/cmake.yml | Adds a 30-minute timeout to the CMake build job. |
| .github/workflows/clang-tidy.yml | Adds a 60-minute timeout to the clang-tidy matrix analysis job. |
| .github/workflows/build-workflow.yml | Adds a 30-minute timeout to the main reusable build workflow job. |
| .github/workflows/alpine-architecture-tests.yml | Adds a 90-minute timeout to the QEMU/emulated Alpine architecture matrix job. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Jobs default to GitHub's 6 hour timeout, so a hung
aptstep recently burned ~6 hours before the run failed. This adds explicittimeout-minutesto every job so hangs fail fast.Tiering
Timeouts are tiered by job weight:
unit-test.ymlcalls reusable workflows, which cannot settimeout-minuteson the caller, so its timeout is set inbuild-workflow.ymlandwolfssl-v5.6.6-build-workflow.yml. Pre-existing timeouts are unchanged.