Nulls not distinct#1609
Open
jkeuhlen wants to merge 8 commits into
Open
Conversation
Resolved conflicts: - persistent-postgresql.cabal: kept both MigrationSpec and NullsNotDistinctTest modules - TH/Internal.hs: merged error message to include both nullsNotDistinct option and getBy warning - Internal.hs: took master's refactored version (migration code moved to Internal/Migration.hs) - Applied NullsNotDistinct changes to the new Internal/Migration.hs location: - Added [Attr] parameter to AddUniqueConstraint - Updated udToPair to return triple including uniqueAttrs - Added NULLS NOT DISTINCT clause in showAlterTable - Updated getAlters and related functions for new tuple types Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
# Conflicts: # persistent-postgresql/ChangeLog.md # persistent/ChangeLog.md
jkeuhlen
commented
Jun 11, 2026
| image: postgres:12-alpine | ||
| # Use a PostgreSQL version that supports UNIQUE NULLS NOT DISTINCT (15+), | ||
| # so the NullsNotDistinctTest suite actually exercises the feature. | ||
| image: postgres:16-alpine |
Contributor
Author
There was a problem hiding this comment.
It's unclear to me if this would generally be desirable, or if there would be a preference to run against a matrix of postgres versions, but 12 is a pretty old version of postgres so I bumped to something more recent here to make sure the tests for this branch are actually meaningful.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting your PR, check that you've:
@sincedeclarations to the Haddockfourmoluon any changed files (restyledwill do this for you, soaccept the suggested changes if it makes them)
.editorconfigandfourmolu.yamlfiles for details)After submitting your PR:
(unreleased)on the ChangelogThis implements 2/3/4 from #1607