Skip to content

fix: make xarray downstream tests work#4043

Merged
d-v-b merged 4 commits into
zarr-developers:mainfrom
d-v-b:zarr-python-downstream-xarray-fix
Jun 6, 2026
Merged

fix: make xarray downstream tests work#4043
d-v-b merged 4 commits into
zarr-developers:mainfrom
d-v-b:zarr-python-downstream-xarray-fix

Conversation

@d-v-b

@d-v-b d-v-b commented Jun 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

xarray downstream test job is broken. this PR will try to fix it. opening as a draft until it works.

closes #4044

dependabot Bot and others added 4 commits May 31, 2026 19:28
@dependabot
chore(deps): bump the actions group across 1 directory with 8 updates (…
8da1333 
…#176)

Bumps the actions group with 8 updates in the / directory:

| Package | From | To |
| --- | --- | --- |
| [prefix-dev/setup-pixi](https://github.com/prefix-dev/setup-pixi) | `0.9.5` | `0.9.6` |
| [codecov/codecov-action](https://github.com/codecov/codecov-action) | `6.0.0` | `6.0.1` |
| [github/issue-metrics](https://github.com/github/issue-metrics) | `4.2.2` | `4.2.7` |
| [j178/prek-action](https://github.com/j178/prek-action) | `2.0.3` | `2.0.4` |
| [actions/upload-artifact](https://github.com/actions/upload-artifact) | `7.0.0` | `7.0.1` |
| [actions/download-artifact](https://github.com/actions/download-artifact) | `7.0.0` | `8.0.1` |
| [pypa/gh-action-pypi-publish](https://github.com/pypa/gh-action-pypi-publish) | `1.13.0` | `1.14.0` |
| [zizmorcore/zizmor-action](https://github.com/zizmorcore/zizmor-action) | `0.5.3` | `0.5.6` |



Updates `prefix-dev/setup-pixi` from 0.9.5 to 0.9.6
- [Release notes](https://github.com/prefix-dev/setup-pixi/releases)
- [Commits](prefix-dev/setup-pixi@1b2de7f...5185adf)

Updates `codecov/codecov-action` from 6.0.0 to 6.0.1
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@57e3a13...e79a696)

Updates `github/issue-metrics` from 4.2.2 to 4.2.7
- [Release notes](https://github.com/github/issue-metrics/releases)
- [Commits](github-community-projects/issue-metrics@c9e9838...1e38d5e)

Updates `j178/prek-action` from 2.0.3 to 2.0.4
- [Release notes](https://github.com/j178/prek-action/releases)
- [Commits](j178/prek-action@6ad8027...bdca6f1)

Updates `actions/upload-artifact` from 7.0.0 to 7.0.1
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v7...043fb46)

Updates `actions/download-artifact` from 7.0.0 to 8.0.1
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](actions/download-artifact@v7...3e5f45b)

Updates `pypa/gh-action-pypi-publish` from 1.13.0 to 1.14.0
- [Release notes](https://github.com/pypa/gh-action-pypi-publish/releases)
- [Commits](pypa/gh-action-pypi-publish@v1.13.0...cef2210)

Updates `zizmorcore/zizmor-action` from 0.5.3 to 0.5.6
- [Release notes](https://github.com/zizmorcore/zizmor-action/releases)
- [Commits](zizmorcore/zizmor-action@b1d7e1f...5f14fd0)

---
updated-dependencies:
- dependency-name: prefix-dev/setup-pixi
  dependency-version: 0.9.6
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: actions
- dependency-name: codecov/codecov-action
  dependency-version: 6.0.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: actions
- dependency-name: github/issue-metrics
  dependency-version: 4.2.7
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: actions
- dependency-name: j178/prek-action
  dependency-version: 2.0.4
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: actions
- dependency-name: actions/upload-artifact
  dependency-version: 7.0.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: actions
- dependency-name: actions/download-artifact
  dependency-version: 8.0.1
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: actions
- dependency-name: pypa/gh-action-pypi-publish
  dependency-version: 1.14.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: actions
- dependency-name: zizmorcore/zizmor-action
  dependency-version: 0.5.6
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: actions
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@d-v-b
Merge branch 'main' of https://github.com/d-v-b/zarr-python
659c734
@d-v-b
Merge branch 'main' of https://github.com/zarr-developers/zarr-python
51c994b
@d-v-b @claude
ci: restrict xarray downstream job to the test-py313 pixi environment
7af2c3b 
setup-pixi installs every environment in xarray's manifest by default,
which drags in `mypy-upstream`. That environment builds numcodecs from
git and fails under newer pixi with `meson-python: error: Unknown option
"pixi-conda-environment"`, breaking the job before any test runs — even
though all our steps only use `test-py313`. Limit installation to the one
environment we actually use.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@d-v-b d-v-b added the downstream Downstream libraries using zarr label Jun 6, 2026
@github-actions github-actions Bot added the needs release notes Automatically applied to PRs which haven't added release notes label Jun 6, 2026
@d-v-b d-v-b marked this pull request as ready for review June 6, 2026 13:38
@d-v-b d-v-b requested a review from maxrjones June 6, 2026 13:38
@d-v-b d-v-b merged commit b9d3964 into zarr-developers:main Jun 6, 2026
35 of 36 checks passed
This was referenced Jun 6, 2026
Merged
Open
d-v-b added a commit that referenced this pull request Jun 10, 2026
@d-v-b @claude
Revert "fix: make xarray downstream tests work" (#4047)
6827a61 
* Revert "fix: make xarray downstream tests work (#4043)"

This reverts commit b9d3964.

* ci: install only the test-py313 pixi environment for xarray downstream

With no committed pixi.lock in pydata/xarray, setup-pixi's bare
`pixi install` solves every environment in the manifest, including
`mypy-upstream`, which sources numcodecs from git and fails under newer
pixi with `meson-python: error: Unknown option "pixi-conda-environment"`
during the solve — before any test runs. Setting `environments:
test-py313` makes setup-pixi run `pixi install -e test-py313`, which
never solves that environment.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* ci: run xarray downstream tests via uv instead of pixi

pixi has no committed lockfile in pydata/xarray, so `pixi install` solves
the entire manifest regardless of `-e <env>` — including the
`mypy-upstream` environment, which sources numcodecs from git and fails
to build under newer pixi with
`meson-python: error: Unknown option "pixi-conda-environment"`. The job
died at environment setup before any test ran, and the per-environment
flag (the previously reverted approach) does not avoid the failing solve.

Install xarray with uv from its checkout instead — the `dev` dependency
group for pytest tooling plus the `io`/`parallel`/`accel` extras for the
zarr-relevant backends — then override zarr with the branch build. Tests
needing an uninstalled backend skip via xarray's `requires_*` markers.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxrjones maxrjones maxrjones approved these changes

Assignees

No one assigned

Labels

downstream Downstream libraries using zarr needs release notes Automatically applied to PRs which haven't added release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

broken xarray downstream tests

2 participants

@d-v-b @maxrjones