Skip to content

fix: copy attributes passed from the user to avoid mutation#4060

Merged
d-v-b merged 3 commits into
zarr-developers:mainfrom
stibrew:main
Jun 11, 2026
Merged

fix: copy attributes passed from the user to avoid mutation#4060
d-v-b merged 3 commits into
zarr-developers:mainfrom
stibrew:main

Conversation

@stibrew

@stibrew stibrew commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

This PR fixes #4059

TODO:

  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actions github-actions Bot added the needs release notes Automatically applied to PRs which haven't added release notes label Jun 11, 2026

@d-v-b d-v-b left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.53%. Comparing base (3d8746a) to head (4b719a9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4060   +/-   ##
=======================================
  Coverage   93.53%   93.53%           
=======================================
  Files          89       89           
  Lines       11901    11901           
=======================================
  Hits        11132    11132           
  Misses        769      769           
Files with missing lines Coverage Δ
src/zarr/core/group.py 95.20% <100.00%> (ø)
src/zarr/core/metadata/common.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@d-v-b

d-v-b commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

@stibrew could you write up a release note for our changelog? see https://zarr.readthedocs.io/en/stable/contributing/#changelog

@github-actions github-actions Bot removed the needs release notes Automatically applied to PRs which haven't added release notes label Jun 11, 2026
@stibrew

stibrew commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

@stibrew could you write up a release note for our changelog? see https://zarr.readthedocs.io/en/stable/contributing/#changelog

Done. Thank you as well!

@d-v-b d-v-b merged commit ea76ec8 into zarr-developers:main Jun 11, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

User-provided attributes dictionary is mutated by the public API

2 participants