Fix invalid Docker image tag on PRs to main#46
Merged
Conversation
docker-publish.yml used `type=sha,prefix={{branch}}-`, but on a
pull_request event the metadata-action `{{branch}}` placeholder is empty,
so the computed tag became `ghcr.io/...:-<sha>` — an invalid reference
that failed every build-and-push job on PRs targeting main (blocking the
develop→main promotion / prod image pipeline). Use a static `sha-` prefix
so the tag is valid on branch pushes, tags, and PRs alike.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
🧪 Comprehensive Test Suite
Full-stack smoke gate runs in the CI workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
build-and-pushjobs failed on every PR targetingmain(e.g. the develop→main promotion PR #45) with:Cause:
docker-publish.ymlhadtype=sha,prefix={{branch}}-. On apull_requestevent the metadata-action{{branch}}placeholder resolves to empty, so the tag became:-<sha>(leading dash → invalid reference).Fix: use a static
prefix=sha-, giving a validsha-<shortsha>tag on branch pushes, version tags, and PRs alike. The other tags (type=ref,event=pr→pr-N, semver,lateston default branch) are unaffected.This unblocks the prod image pipeline for PRs to main.
🤖 Generated with Claude Code