[grid] fix Global Account frontend auth sample#563
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This was referenced Jun 9, 2026
Contributor
Author
This was referenced Jun 9, 2026
Contributor
Greptile SummaryThis PR fixes two correctness issues in the Global Account frontend authentication sample for the real (non-sandbox) passkey reauth flow.
Confidence Score: 5/5Safe to merge — both changes are correctness fixes to the production signing path in a sample file, and the sandbox path (the default) is untouched. The two changes (challenge encoding and stamp format) are targeted and internally consistent. The removed helpers are genuinely unused after the change, and the remaining utility functions are still present and used correctly. No files require special attention.
|
| Filename | Overview |
|---|---|
| samples/frontend/src/steps/embeddedWallet/AuthenticateAndSign.tsx | Fixes WebAuthn challenge encoding and replaces raw base64 DER signature output with a Turnkey API-key stamp; removes two now-unused helpers. Changes are self-consistent and sandbox path is unaffected. |
Reviews (2): Last reviewed commit: "[grid] fix Global Account frontend auth ..." | Re-trigger Greptile
f7e3508 to
20eb971
Compare
6a21cc1 to
50c9215
Compare
50c9215 to
060c68b
Compare
carsonp6
approved these changes
Jun 10, 2026
Contributor
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
navigator.credentials.get(), instead of base64url-decoding it.Grid-Wallet-Signatureas the Turnkey API-key stamp shape Grid expects: base64url JSON withpublicKey,scheme, and DER signature hex.Validation
npm run buildinsamples/frontendmake buildat the stack tip