Skip to content

[grid] fix Global Account sandbox docs#567

Merged
DhruvPareek merged 1 commit into
mainfrom
dp/fix-global-account-sandbox-readme-docs
Jun 10, 2026
Merged

[grid] fix Global Account sandbox docs#567
DhruvPareek merged 1 commit into
mainfrom
dp/fix-global-account-sandbox-readme-docs

Conversation

@DhruvPareek

@DhruvPareek DhruvPareek commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Fix the sandbox passkey verify curl example to echo the full Request:<uuid> header value.
  • Remove the unused Request-Id header from the OAuth sandbox verify example.
  • Update the scripts README to say the helper has four subcommands and clarify that bootstrap step 1.4 only issues the EMAIL_OTP challenge.
  • Clarify the frontend sandbox comments: default sandbox mode uses legacy magic signatures as shortcuts, while production-shaped sandbox tests can use real decryptable bundles and stamps.

Validation

  • npm run build in samples/frontend
  • make build at the stack tip

@vercel

vercel Bot commented Jun 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
grid-flow-builder Ignored Ignored Preview Jun 10, 2026 6:38pm

Request Review

@DhruvPareek DhruvPareek marked this pull request as ready for review June 9, 2026 20:14
@greptile-apps

greptile-apps Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Documentation-only fixes to the Global Account sandbox guides: corrects a malformed Request-Id header value in the passkey curl example, removes an inapplicable header from the OAuth example, fixes the subcommand count in the scripts README, and clarifies comment language in the frontend sample.

  • sandbox-global-account-magic.mdx: Passkey Request-Id now echoes the full Request:<uuid> format; OAuth example no longer includes an unneeded Request-Id header.
  • scripts/README.md: Subcommand count corrected to four (gen-keypair, encrypt-otp, decrypt-bundle, stamp); section 1.4 heading and body now accurately describe issuing the EMAIL_OTP challenge rather than completing the full verify.
  • AuthenticateAndSign.tsx: Comments updated to distinguish the default sandbox shortcut path from a production-shaped sandbox test.

Confidence Score: 5/5

All three files contain only documentation and comment corrections — no logic, runtime behaviour, or data handling is touched.

Every change is a copy fix: a malformed header value corrected, a stale header removed, a wrong count updated, and comment wording tightened. None of the changes affect compiled code, API contracts, or runtime paths.

No files require special attention.

Important Files Changed

Filename Overview
mintlify/snippets/sandbox-global-account-magic.mdx Fixed two curl examples: added the Request: prefix to the passkey Request-Id header, and removed the unused Request-Id header from the OAuth verify example.
samples/frontend/src/steps/embeddedWallet/AuthenticateAndSign.tsx Comment-only update clarifying that default sandbox mode uses intentional shortcuts, and that the wallet signature value is a legacy magic value.
scripts/README.md Corrected subcommand count from three to four (matching gen-keypair, encrypt-otp, decrypt-bundle, stamp), and reworded section 1.4 to clarify the bootstrap step issues a challenge rather than performing a full verify.

Sequence Diagram

sequenceDiagram
    participant Client
    participant Grid as Grid API (Sandbox)

    Note over Client,Grid: Passkey verify (corrected docs)
    Client->>Grid: "POST /auth/credentials/{id}/challenge"
    Grid-->>Client: "{ requestId: "Request:uuid", challenge }"
    Client->>Grid: "POST /auth/credentials/{id}/verify + Request-Id: Request:uuid"
    Grid-->>Client: "{ encryptedSessionSigningKey }"

    Note over Client,Grid: OAuth verify (header removed from docs)
    Client->>Grid: "POST /auth/credentials/{id}/verify + { oidcToken, clientPublicKey }"
    Grid-->>Client: "{ encryptedSessionSigningKey }"

    Note over Client,Grid: scripts/README.md bootstrap (section 1.4)
    Client->>Grid: "POST /auth/credentials/{id}/challenge"
    Grid-->>Client: OTP email sent (sandbox: use 000000)
Loading

Reviews (4): Last reviewed commit: "[grid] fix Global Account sandbox docs" | Re-trigger Greptile

@DhruvPareek DhruvPareek force-pushed the dp/fix-global-account-auth-snippets branch from 9aa1eda to 2e284b5 Compare June 10, 2026 17:09
@DhruvPareek DhruvPareek force-pushed the dp/fix-global-account-sandbox-readme-docs branch from ae10b88 to dce3110 Compare June 10, 2026 17:09
carsonp6
carsonp6 previously approved these changes Jun 10, 2026
@DhruvPareek DhruvPareek force-pushed the dp/fix-global-account-auth-snippets branch from 2e284b5 to 7da0598 Compare June 10, 2026 18:26
@DhruvPareek DhruvPareek force-pushed the dp/fix-global-account-sandbox-readme-docs branch from dce3110 to fce4599 Compare June 10, 2026 18:26

@restamp-bot restamp-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fce4599 is a pure rebase onto 7da0598. Approving based on @carsonp6's previous approval of dce3110.

@DhruvPareek DhruvPareek force-pushed the dp/fix-global-account-auth-snippets branch from 7da0598 to 460893f Compare June 10, 2026 18:28
@DhruvPareek DhruvPareek force-pushed the dp/fix-global-account-sandbox-readme-docs branch from fce4599 to 62b4494 Compare June 10, 2026 18:29

@restamp-bot restamp-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

62b4494 is a pure rebase onto 460893f. Approving based on @carsonp6's previous approval of dce3110.

@DhruvPareek DhruvPareek force-pushed the dp/fix-global-account-auth-snippets branch 2 times, most recently from d409949 to f856ba9 Compare June 10, 2026 18:34
@DhruvPareek DhruvPareek force-pushed the dp/fix-global-account-sandbox-readme-docs branch from 62b4494 to c93756e Compare June 10, 2026 18:34

@restamp-bot restamp-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c93756e is a pure rebase onto f856ba9. Approving based on @carsonp6's previous approval of dce3110.

@DhruvPareek DhruvPareek changed the base branch from dp/fix-global-account-auth-snippets to graphite-base/567 June 10, 2026 18:36

@restamp-bot restamp-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c93756e is a pure rebase onto f856ba9. Approving based on @carsonp6's previous approval of dce3110.

@DhruvPareek DhruvPareek force-pushed the dp/fix-global-account-sandbox-readme-docs branch from c93756e to 01c6cc1 Compare June 10, 2026 18:36

@restamp-bot restamp-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

01c6cc1 is a pure rebase onto 536a5ac. Approving based on @carsonp6's previous approval of dce3110.

restamp-bot[bot]
restamp-bot Bot previously approved these changes Jun 10, 2026

@restamp-bot restamp-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

01c6cc1 is a pure rebase onto 536a5ac. Approving based on @carsonp6's previous approval of dce3110.

@graphite-app graphite-app Bot changed the base branch from graphite-base/567 to main June 10, 2026 18:37
@graphite-app graphite-app Bot dismissed stale reviews from restamp-bot[bot] and carsonp6 June 10, 2026 18:37

The base branch was changed.

@DhruvPareek DhruvPareek force-pushed the dp/fix-global-account-sandbox-readme-docs branch from 01c6cc1 to 979710e Compare June 10, 2026 18:37

@restamp-bot restamp-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

01c6cc1 is a pure rebase onto 536a5ac. Approving based on @carsonp6's previous approval of dce3110.

@restamp-bot restamp-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

979710e is a pure rebase onto 536a5ac. Approving based on @carsonp6's previous approval of dce3110.

@DhruvPareek DhruvPareek merged commit 3a81902 into main Jun 10, 2026
11 checks passed

Copy link
Copy Markdown
Contributor Author

Merge activity

@DhruvPareek DhruvPareek deleted the dp/fix-global-account-sandbox-readme-docs branch June 10, 2026 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants