sync Grid Visualizer CNY data with OpenAPI schema#576
Conversation
CNY account now supports both BANK_TRANSFER and MOBILE_MONEY rails per commit 2442b86. Updates visualizer data files to match. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummaryThis PR syncs the Grid Visualizer's CNY data with the OpenAPI schema changes from #554, adding
Confidence Score: 4/5Straightforward data-only change that mirrors the OpenAPI schema; no logic is altered. Both changed files are static data definitions with no runtime logic. The new account-types.ts — the
|
| Filename | Overview |
|---|---|
| components/grid-visualizer/src/data/account-types.ts | Adds accountNumber field with rail-specific description to CNY_ACCOUNT; bankName has no description despite applying to both rails per the OpenAPI schema. |
| components/grid-visualizer/src/data/currencies.ts | Adds 'Mobile Money' to CNY allRails array, matching the pattern already used for other multi-rail currencies like SLV. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
CNY[CNY Currency] --> allRails["allRails: ['Bank Transfer', 'Mobile Money']"]
allRails --> BT[Bank Transfer rail]
allRails --> MM[Mobile Money rail]
BT --> BT_fields["accountNumber NEW\nbankName"]
MM --> MM_fields["phoneNumber\nbankName"]
CNY_ACCOUNT[CNY_ACCOUNT spec] --> f1["accountNumber — For BANK_TRANSFER rail NEW"]
CNY_ACCOUNT --> f2["phoneNumber — For MOBILE_MONEY rail"]
CNY_ACCOUNT --> f3["bankName — both rails per OpenAPI schema"]
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
components/grid-visualizer/src/data/account-types.ts:376
The `bankName` field has no description, which leaves it ambiguous for users who see rail-scoped descriptions on the adjacent fields. Per `CnyAccountInfoBase.yaml`, `bankName` is required for **both** rails ("The name of the bank or mobile-wallet provider"), so a short clarifying note would keep the intent readable alongside the per-rail descriptions above it.
```suggestion
{ name: 'bankName', example: 'Industrial and Commercial Bank of China', description: 'Required for both rails (bank name or mobile wallet provider)' },
```
Reviews (1): Last reviewed commit: "sync Grid Visualizer CNY data with OpenA..." | Re-trigger Greptile
| { name: 'phoneNumber', example: '+8613812345678' }, | ||
| { name: 'accountNumber', example: '1234567890', description: 'For BANK_TRANSFER rail' }, | ||
| { name: 'phoneNumber', example: '+8613812345678', description: 'For MOBILE_MONEY rail' }, | ||
| { name: 'bankName', example: 'Industrial and Commercial Bank of China' }, |
There was a problem hiding this comment.
The
bankName field has no description, which leaves it ambiguous for users who see rail-scoped descriptions on the adjacent fields. Per CnyAccountInfoBase.yaml, bankName is required for both rails ("The name of the bank or mobile-wallet provider"), so a short clarifying note would keep the intent readable alongside the per-rail descriptions above it.
| { name: 'bankName', example: 'Industrial and Commercial Bank of China' }, | |
| { name: 'bankName', example: 'Industrial and Commercial Bank of China', description: 'Required for both rails (bank name or mobile wallet provider)' }, |
Prompt To Fix With AI
This is a comment left during a code review.
Path: components/grid-visualizer/src/data/account-types.ts
Line: 376
Comment:
The `bankName` field has no description, which leaves it ambiguous for users who see rail-scoped descriptions on the adjacent fields. Per `CnyAccountInfoBase.yaml`, `bankName` is required for **both** rails ("The name of the bank or mobile-wallet provider"), so a short clarifying note would keep the intent readable alongside the per-rail descriptions above it.
```suggestion
{ name: 'bankName', example: 'Industrial and Commercial Bank of China', description: 'Required for both rails (bank name or mobile wallet provider)' },
```
How can I resolve this? If you propose a fix, please make it concise.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Summary
Mobile Moneyto CNYallRailsarray (alongsideBank Transfer)accountNumberfield toCNY_ACCOUNTspec for BANK_TRANSFER railThese changes sync the Grid Visualizer data with the OpenAPI schema updates from #554 (commit 2442b86), which added CNY bank-transfer rail (B2B) alongside mobile wallet.
Test plan
accountNumberwhen BANK_TRANSFER rail is selected🤖 Generated with Claude Code