Skip to content

sync Grid Visualizer CNY data with OpenAPI schema#576

Merged
pengying merged 1 commit into
mainfrom
docs/sync-20260612
Jun 12, 2026
Merged

sync Grid Visualizer CNY data with OpenAPI schema#576
pengying merged 1 commit into
mainfrom
docs/sync-20260612

Conversation

@claude

@claude claude Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Added Mobile Money to CNY allRails array (alongside Bank Transfer)
  • Added accountNumber field to CNY_ACCOUNT spec for BANK_TRANSFER rail
  • Added field descriptions clarifying which fields are for which rail

These changes sync the Grid Visualizer data with the OpenAPI schema updates from #554 (commit 2442b86), which added CNY bank-transfer rail (B2B) alongside mobile wallet.

Test plan

  • Verify Grid Visualizer generates correct CNY account info for both rails
  • Verify code samples include accountNumber when BANK_TRANSFER rail is selected

🤖 Generated with Claude Code

CNY account now supports both BANK_TRANSFER and MOBILE_MONEY rails per
commit 2442b86. Updates visualizer data files to match.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@claude claude Bot requested review from pengying and shreyav June 12, 2026 09:31
@vercel

vercel Bot commented Jun 12, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
grid-flow-builder Ready Ready Preview, Comment Jun 12, 2026 9:31am

Request Review

@greptile-apps

greptile-apps Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR syncs the Grid Visualizer's CNY data with the OpenAPI schema changes from #554, adding Mobile Money as a second rail and a new accountNumber field for the BANK_TRANSFER path.

  • currencies.ts: 'Mobile Money' appended to CNY's allRails array, matching the existing pattern for other dual-rail currencies (e.g. SLV).
  • account-types.ts: accountNumber added to CNY_ACCOUNT fields with a 'For BANK_TRANSFER rail' description; phoneNumber gains a matching 'For MOBILE_MONEY rail' description. bankName, which the OpenAPI schema requires for both rails, is left without a description.

Confidence Score: 4/5

Straightforward data-only change that mirrors the OpenAPI schema; no logic is altered.

Both changed files are static data definitions with no runtime logic. The new accountNumber field and additional Mobile Money rail correctly reflect the upstream OpenAPI schema. The only gap is bankName missing a description clarifying it covers both rails, which could cause UI confusion but doesn't break functionality.

account-types.ts — the bankName entry in CNY_ACCOUNT is the only place that merits a second look.

Important Files Changed

Filename Overview
components/grid-visualizer/src/data/account-types.ts Adds accountNumber field with rail-specific description to CNY_ACCOUNT; bankName has no description despite applying to both rails per the OpenAPI schema.
components/grid-visualizer/src/data/currencies.ts Adds 'Mobile Money' to CNY allRails array, matching the pattern already used for other multi-rail currencies like SLV.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    CNY[CNY Currency] --> allRails["allRails: ['Bank Transfer', 'Mobile Money']"]
    allRails --> BT[Bank Transfer rail]
    allRails --> MM[Mobile Money rail]

    BT --> BT_fields["accountNumber NEW\nbankName"]
    MM --> MM_fields["phoneNumber\nbankName"]

    CNY_ACCOUNT[CNY_ACCOUNT spec] --> f1["accountNumber — For BANK_TRANSFER rail NEW"]
    CNY_ACCOUNT --> f2["phoneNumber — For MOBILE_MONEY rail"]
    CNY_ACCOUNT --> f3["bankName — both rails per OpenAPI schema"]
Loading
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
components/grid-visualizer/src/data/account-types.ts:376
The `bankName` field has no description, which leaves it ambiguous for users who see rail-scoped descriptions on the adjacent fields. Per `CnyAccountInfoBase.yaml`, `bankName` is required for **both** rails ("The name of the bank or mobile-wallet provider"), so a short clarifying note would keep the intent readable alongside the per-rail descriptions above it.

```suggestion
      { name: 'bankName', example: 'Industrial and Commercial Bank of China', description: 'Required for both rails (bank name or mobile wallet provider)' },
```

Reviews (1): Last reviewed commit: "sync Grid Visualizer CNY data with OpenA..." | Re-trigger Greptile

{ name: 'phoneNumber', example: '+8613812345678' },
{ name: 'accountNumber', example: '1234567890', description: 'For BANK_TRANSFER rail' },
{ name: 'phoneNumber', example: '+8613812345678', description: 'For MOBILE_MONEY rail' },
{ name: 'bankName', example: 'Industrial and Commercial Bank of China' },

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 The bankName field has no description, which leaves it ambiguous for users who see rail-scoped descriptions on the adjacent fields. Per CnyAccountInfoBase.yaml, bankName is required for both rails ("The name of the bank or mobile-wallet provider"), so a short clarifying note would keep the intent readable alongside the per-rail descriptions above it.

Suggested change
{ name: 'bankName', example: 'Industrial and Commercial Bank of China' },
{ name: 'bankName', example: 'Industrial and Commercial Bank of China', description: 'Required for both rails (bank name or mobile wallet provider)' },
Prompt To Fix With AI
This is a comment left during a code review.
Path: components/grid-visualizer/src/data/account-types.ts
Line: 376

Comment:
The `bankName` field has no description, which leaves it ambiguous for users who see rail-scoped descriptions on the adjacent fields. Per `CnyAccountInfoBase.yaml`, `bankName` is required for **both** rails ("The name of the bank or mobile-wallet provider"), so a short clarifying note would keep the intent readable alongside the per-rail descriptions above it.

```suggestion
      { name: 'bankName', example: 'Industrial and Commercial Bank of China', description: 'Required for both rails (bank name or mobile wallet provider)' },
```

How can I resolve this? If you propose a fix, please make it concise.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@pengying pengying merged commit 9bf03d0 into main Jun 12, 2026
8 checks passed
@pengying pengying deleted the docs/sync-20260612 branch June 12, 2026 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant