Skip to content

sync Grid Visualizer CNY data with OpenAPI schema #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pengying merged 1 commit into from
Jun 12, 2026
+3 −2
Merged

sync Grid Visualizer CNY data with OpenAPI schema #576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion components/grid-visualizer/src/data/account-types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,8 @@ export const accountTypeSpecs: Record<string, AccountTypeSpec> = {
CNY_ACCOUNT: {
accountType: 'CNY_ACCOUNT',
fields: [
{ name: 'phoneNumber', example: '+8613812345678' },
{ name: 'accountNumber', example: '1234567890', description: 'For BANK_TRANSFER rail' },
{ name: 'phoneNumber', example: '+8613812345678', description: 'For MOBILE_MONEY rail' },
{ name: 'bankName', example: 'Industrial and Commercial Bank of China' },

@greptile-apps greptile-apps Bot Jun 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 The bankName field has no description, which leaves it ambiguous for users who see rail-scoped descriptions on the adjacent fields. Per CnyAccountInfoBase.yaml, bankName is required for both rails ("The name of the bank or mobile-wallet provider"), so a short clarifying note would keep the intent readable alongside the per-rail descriptions above it.

Suggested change
{ name: 'bankName', example: 'Industrial and Commercial Bank of China' },
{ name: 'bankName', example: 'Industrial and Commercial Bank of China', description: 'Required for both rails (bank name or mobile wallet provider)' },
Prompt To Fix With AI 
This is a comment left during a code review.
Path: components/grid-visualizer/src/data/account-types.ts
Line: 376

Comment:
The `bankName` field has no description, which leaves it ambiguous for users who see rail-scoped descriptions on the adjacent fields. Per `CnyAccountInfoBase.yaml`, `bankName` is required for **both** rails ("The name of the bank or mobile-wallet provider"), so a short clarifying note would keep the intent readable alongside the per-rail descriptions above it.

```suggestion
      { name: 'bankName', example: 'Industrial and Commercial Bank of China', description: 'Required for both rails (bank name or mobile wallet provider)' },
```

How can I resolve this? If you propose a fix, please make it concise.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

],
beneficiaryRequired: true,
Expand Down
2 changes: 1 addition & 1 deletion components/grid-visualizer/src/data/currencies.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ export const currencies: FiatCurrency[] = [
accountType: 'CNY_ACCOUNT',
accountLabel: 'Chinese Bank Account',
instantRails: [],
allRails: ['Bank Transfer'],
allRails: ['Bank Transfer', 'Mobile Money'],
examplePerson: { fullName: 'Wei Zhang', nationality: 'CN' },
},
];
Loading