Skip to content

feat(PowerSync): add attachments support#9

Open
Chriztiaan wants to merge 4 commits into
mainfrom
feat/powersync-attachments
Open

feat(PowerSync): add attachments support#9
Chriztiaan wants to merge 4 commits into
mainfrom
feat/powersync-attachments

Conversation

@Chriztiaan

@Chriztiaan Chriztiaan commented Jun 18, 2026

Copy link
Copy Markdown

Derived from Steven's efforts in powersync-ja/powersync-js#983, and addresses TanStack#1563.

Problem

PowerSync ships an attachment helper for syncing files (photos, documents) between local and remote storage. It's separate from regular synced tables: a local-only attachments table tracks each file's lifecycle (QUEUED_UPLOAD, SYNCED, QUEUED_DELETE), and an AttachmentQueue drives uploads/downloads in the background.

TanStackDB, on the other hand, gives you an optimistic, reactive, joinable view over synced data. For users who want to use the attachment helper alongside the PowerSync+TanstackDB integration there are blockers. Saving a file (in the local-only attachments table) and associating it with a record (e.g. setting user.photo_id) are two independent writes which could make data races and fatal errors a problem for data consistency.

The original POC (powersync-js#983) proved this integration was viable. This PR productionises a a subset of it as reusable functionality.

Solution

A TanStackDBAttachmentQueue that extends the SDK's AttachmentQueue (for saving and deleting a file) and backs it with a TanStack DB collection.

The package owns the collection-backed saveFile/delete implementation and leaves the wiring to the application (covered in documentation).

Future Work

After this has been released, we can merge the changes made to the PowerSync JS TanstackDB demo.

AI Disclosure

I used Claude Opus to help investigate, implement, and verify this work.

@Chriztiaan Chriztiaan marked this pull request as ready for review June 23, 2026 12:02
@Chriztiaan Chriztiaan changed the title feat: add attachments support feat(PowerSync): add attachments support Jun 23, 2026

@stevensJourney stevensJourney left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I'm happy with the approach here. Left a few comments, mostly nits.

} from '@powersync/common'
import type { Collection } from '@tanstack/db'

export type AttachmentQueueRow = (typeof _tmpSchema)['types']['attachments']

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Can't we use AttachmentRecord here?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we can. The types differ slightly (media_type for the tsdb version vs mediaType for common):
I believe this is because the typing for the collection uses the snakecase fields.

image

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see now!

I think the best fix would be to export some record level type from the common SDK. After checking, the type we have here isn't actually very useful (does not contain the actual columns)

image

The general type extraction utilities fail for AttachmentTable since this the columns are only defined inside the constructor's super call.

In the common SDK, something like this could work

const ATTACHMENT_TABLE_COLUMNS = {
  filename: column.text,
  local_uri: column.text,
  timestamp: column.integer,
  size: column.integer,
  media_type: column.text,
  state: column.integer, // Corresponds to AttachmentState
  has_synced: column.integer,
  meta_data: column.text
};

/**
 * AttachmentTable defines the schema for the attachment queue table.
 *
 * @alpha
 */
export class AttachmentTable extends Table<typeof ATTACHMENT_TABLE_COLUMNS> {
  constructor(options?: AttachmentTableOptions) {
    super(ATTACHMENT_TABLE_COLUMNS, {
      ...options,
      viewName: options?.viewName ?? ATTACHMENT_TABLE,
      localOnly: true,
      insertOnly: false
    });
  }
}

export type AttachmentTableRecord = RowType<AttachmentTable>;

export interface DeleteFileTanStackOptions {
id: string
/** *
* Note that this is called inside a synchronous TanStackDB transaction,

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we call this in a synchronous transaction invocation, how can this method reliably be async?

`saveFileTanStack` writes the file, inserts the attachment record into your collection, and runs your `updateHook` mutations in the same transaction. Use the hook to insert or update the row that references the new attachment, so both land together or not at all.

```ts
await attachmentQueue.saveFileTanStack({

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a nit, and I don't have the strongest opinion on this, but the saveFileTanStack is a bit of a mouthful. Maybe save (just to distinguish it from the base method)?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tricky one. Will ponder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants