forked from TanStack/db
-
Notifications
You must be signed in to change notification settings - Fork 0
feat(PowerSync): add attachments support #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Chriztiaan
wants to merge
6
commits into
main
Choose a base branch
from
feat/powersync-attachments
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
3124c9e
Added attachments support.
Chriztiaan d18ab19
Types and tests.
Chriztiaan 91c24c6
Docs.
Chriztiaan 3770d3b
changeset.
Chriztiaan 38af8c5
Rename saveFileTanStack => save, deleteFIleTanStack => delete.
Chriztiaan d82ffc2
Made `updateHook` synchronous and updated `AttachmentQueueRow` typing.
Chriztiaan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| '@tanstack/powersync-db-collection': patch | ||
| --- | ||
|
|
||
| Add attachments support via `TanStackDBAttachmentQueue`. This extends the PowerSync SDK's `AttachmentQueue` and backs it with | ||
| a TanStack DB collection, so file uploads/deletes are managed atomically alongside the relational data. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,156 @@ | ||
| import { | ||
| AttachmentQueue, | ||
| AttachmentState | ||
| } from '@powersync/common' | ||
| import { createTransaction } from '@tanstack/db' | ||
| import { PowerSyncTransactor } from './PowerSyncTransactor' | ||
|
|
||
| import type { | ||
| AbstractPowerSyncDatabase, | ||
| AttachmentData, | ||
| AttachmentQueueOptions, | ||
|
|
||
| AttachmentTable} from '@powersync/common' | ||
| import type { Collection } from '@tanstack/db' | ||
| import type { OptionalExtractedTable } from './helpers' | ||
|
|
||
| export type TanStackDBAttachmentQueueOptions = AttachmentQueueOptions & { | ||
| /** | ||
| * For TanStack, we want access to the synced TanStackDB collection. | ||
| * In order to have the same relational data be set in a single transaction. | ||
| * This also allows for joining both TanStackDB collections. | ||
| */ | ||
| attachmentsCollection: Collection<AttachmentQueueRow, string> | ||
| } | ||
|
|
||
| export interface SaveOptions { | ||
| data: AttachmentData | ||
| fileExtension: string | ||
| mediaType?: string | ||
| metaData?: string | ||
| id?: string | ||
| /** | ||
| * Called within the same TanStackDB transaction as the attachment write, | ||
| * so any mutations made to other collections are committed atomically with it. | ||
| */ | ||
| updateHook?: (attachment: AttachmentQueueRow) => void | ||
| } | ||
|
|
||
| export interface DeleteOptions { | ||
| id: string | ||
| /** | ||
| * Called within the same TanStackDB transaction as the attachment write, | ||
| * so any mutations made to other collections are committed atomically with it. | ||
| */ | ||
| updateHook?: (attachment: AttachmentQueueRow) => void | ||
| } | ||
|
|
||
| export type AttachmentQueueRow = OptionalExtractedTable<AttachmentTable> | ||
|
|
||
| /** | ||
| * A custom extension of the PowerSyncAttachmentQueue for TanStackDB. | ||
| */ | ||
| export class TanStackDBAttachmentQueue extends AttachmentQueue { | ||
| readonly powersync: AbstractPowerSyncDatabase | ||
| readonly collection: Collection<AttachmentQueueRow, string> | ||
|
|
||
| constructor(params: TanStackDBAttachmentQueueOptions) { | ||
| super(params) | ||
| this.powersync = params.db | ||
| this.collection = params.attachmentsCollection | ||
| } | ||
|
|
||
| /** | ||
| * Saves a file to local storage and queues it for upload to remote storage. | ||
| * | ||
| * Exposes an `updateHook` option which is called inside a TanStackDB transaction, | ||
| * relational associations with the provided attachment ID should be made in this hook. | ||
| */ | ||
| async save({ | ||
| data, | ||
| fileExtension, | ||
| mediaType, | ||
| metaData, | ||
| id, | ||
| updateHook, | ||
| }: SaveOptions): Promise<AttachmentQueueRow> { | ||
| const resolvedId = id ?? (await this.generateAttachmentId()) | ||
| const filename = `${resolvedId}.${fileExtension}` | ||
| const localUri = this.localStorage.getLocalUri(filename) | ||
| const size = await this.localStorage.saveFile(localUri, data) | ||
|
|
||
| const attachment: AttachmentQueueRow = { | ||
| id: resolvedId, | ||
| filename, | ||
| media_type: mediaType ?? null, | ||
| local_uri: localUri, | ||
| state: AttachmentState.QUEUED_UPLOAD, | ||
| has_synced: 0, | ||
| size, | ||
| timestamp: new Date().getTime(), | ||
| meta_data: metaData ?? null, | ||
| } | ||
|
|
||
| /** | ||
| * We use the attachmentService lock to prevent attachment queue race conditions — specifically, | ||
| * it stops the watcher from treating a newly inserted attachment record as one that needs | ||
| * to be downloaded. | ||
| * */ | ||
| await this.withAttachmentContext(async (ctx) => { | ||
| const tanStackDBTransaction = createTransaction({ | ||
| autoCommit: false, | ||
| mutationFn: async ({ transaction }) => { | ||
| await new PowerSyncTransactor({ | ||
| database: ctx.db, | ||
| }).applyTransaction(transaction) | ||
| }, | ||
| }) | ||
|
|
||
| tanStackDBTransaction.mutate(() => { | ||
| this.collection.insert(attachment) | ||
| // allow the user to associate values in this transaction | ||
| updateHook?.(attachment) | ||
| }) | ||
|
|
||
| await tanStackDBTransaction.commit() | ||
| }) | ||
|
|
||
| return attachment | ||
| } | ||
|
|
||
| /** | ||
| * Queues a file for deletion from local and remote storage. | ||
| * | ||
| * Exposes an `updateHook` option which is called inside a TanStackDB transaction, | ||
| * relational associations with the provided attachment ID should be cleaned up in this hook. | ||
| */ | ||
| async delete({ id, updateHook }: DeleteOptions): Promise<void> { | ||
| await this.withAttachmentContext(async (ctx) => { | ||
| const tanStackDBTransaction = createTransaction({ | ||
| autoCommit: false, | ||
| mutationFn: async ({ transaction }) => { | ||
| await new PowerSyncTransactor({ | ||
| database: ctx.db, | ||
| }).applyTransaction(transaction) | ||
| }, | ||
| }) | ||
|
|
||
| tanStackDBTransaction.mutate(() => { | ||
| const attachment = this.collection.get(id) | ||
| if (!attachment) { | ||
| throw new Error(`Attachment with id ${id} not found`) | ||
| } | ||
|
|
||
| this.collection.update(id, (draft) => { | ||
| draft.state = AttachmentState.QUEUED_DELETE | ||
| draft.has_synced = 0 | ||
| }) | ||
|
|
||
| // allow the user to associate values in this transaction | ||
| updateHook?.(attachment) | ||
| }) | ||
|
|
||
| await tanStackDBTransaction.commit() | ||
| }) | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.